Review Request: Enable call holding in ktp-call-ui

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105829/#review16816
-----------------------------------------------------------


Few smaller nitpicks below and we can ship it..


src/call-window.h
<http://git.reviewboard.kde.org/r/105829/#comment13144>

    The slot names are not very good. The hold(..) is ok-ish, but the holdStatus is not. It would be much better if it was something like onHoldStatusChanged(..) or setHoldStatus(..) or alike. The current name suggest it returns a hold status, which is not true.



src/call-window.h
<http://git.reviewboard.kde.org/r/105829/#comment13142>

    Pointer star alignment



src/call-window.cpp
<http://git.reviewboard.kde.org/r/105829/#comment13143>

    Pointer star alignment



src/call-window.cpp
<http://git.reviewboard.kde.org/r/105829/#comment13145>

    I don't like this error string. Can we find better wording?


- Martin Klapetek


On Aug. 2, 2012, 6:22 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105829/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2012, 6:22 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Enables call holding in ktp-call-ui
> 
> 
> Diffs
> -----
> 
>   src/call-manager.cpp ad712c077b8723ecc66c5c31f3d8ba3caf9ef690 
>   src/call-window.h d8741c332f9ee104a00776816da968916be5ea10 
>   src/call-window.cpp 32503f2d09d7666127279b8071c77694bbdc8153 
>   src/call-window.ui 14144cc636880c60879e94d4936734c2002ad62e 
>   src/main.cpp d836052849de32b547ef440a22f241e60308b7d8 
> 
> Diff: http://git.reviewboard.kde.org/r/105829/diff/
> 
> 
> Testing
> -------
> 
> Successfully held and unheld calls using ktp-call-ui
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120803/34347347/attachment.html>