Review Request: [logviewer] Add links to previous and next conversations to empty logs too

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105762/#review16791
-----------------------------------------------------------



logviewer/conversation-date-picker.cpp
<http://git.reviewboard.kde.org/r/105762/#comment13079>

    Right, this has taken me about fifteen minutes to understand, and as such either needs more comments or changing. 
    
    A simple comment "if m_setDates contains the selected dates select the next entry in m_setDates. Otherwise search..."
    
    
    however I think all of this entire function can be replaced with:
    
    i = qUpperBound(m_setDates, date());
    if (i.hasNext) {
      return i.next();
    } else {
     return QDate();
    }
    
    Rather than having two different search methods. previous date being the same but with prev and qLowerBound.
    
    (not tested)
    


- David Edmundson


On July 27, 2012, 7:42 p.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105762/
> -----------------------------------------------------------
> 
> (Updated July 27, 2012, 7:42 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add "Previous conversation" and "Next conversation" links to logview even when the chat log for selected date is empty, so that it's easy to jump to nearest date with some non-empty chat log.
> 
> 
> This addresses bug 304137.
>     http://bugs.kde.org/show_bug.cgi?id=304137
> 
> 
> Diffs
> -----
> 
>   logviewer/conversation-date-picker.cpp c6bbf2e 
>   logviewer/log-viewer.cpp 5866cdb 
> 
> Diff: http://git.reviewboard.kde.org/r/105762/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vratil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120802/b3a81eb7/attachment.html>