Review Request: Make the kded module use async dbus calls

Simon Persson simonpersson1 at gmail.com
Wed Aug 1 13:00:10 UTC 2012


On Wednesday 01 August 2012 12:41:23 Martin Klapetek wrote:
> Description
> -------
> 
> I reworked the kded module to use async dbus calls. Now when it detects a
> player, it queries for all its properties (to save some roundtrips) and if
> it finds the player is playing, it sets the song info as the presence.
> 
> 
> Diffs (updated)
> -----
> 
>   telepathy-mpris.h de45cec
>   telepathy-mpris.cpp 8386dd9
> 
> Diff: http://git.reviewboard.kde.org/r/105813/diff/
> 

The constructor of QDBusInterface does syncronous calls. That's where phonon 
was sitting waiting for kded. 

Just thought I would mention that.. I don't know of any alternatives.

Regards, Simon
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120801/ffe4df27/attachment.html>


More information about the KDE-Telepathy mailing list