Review Request: Make the kded module use async dbus calls

Martin Klapetek martin.klapetek at gmail.com
Wed Aug 1 12:41:23 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105813/
-----------------------------------------------------------

(Updated Aug. 1, 2012, 12:41 p.m.)


Review request for Telepathy.


Changes
-------

Delete the QDBusPendingCallWatcher after using it.


Description
-------

I reworked the kded module to use async dbus calls. Now when it detects a player, it queries for all its properties (to save some roundtrips) and if it finds the player is playing, it sets the song info as the presence.


Diffs (updated)
-----

  telepathy-mpris.h de45cec 
  telepathy-mpris.cpp 8386dd9 

Diff: http://git.reviewboard.kde.org/r/105813/diff/


Testing
-------

Tested with clementine.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120801/214f1641/attachment-0001.html>


More information about the KDE-Telepathy mailing list