Review Request: Proper behavior while chatting

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105811/#review16757
-----------------------------------------------------------


This review has been submitted with commit 0649ecab265021049c5b69d258a6882783e0bd57 by Aleix Pol to branch master.

- Commit Hook


On Aug. 1, 2012, 11:56 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105811/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2012, 11:56 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> One of the long running problems of this plasmoid was that the view kept jumping while chatting and sometimes you didn't see what was going on. I've been investigating a lot this issue (also because it happened in Muon Discover as well on the updates log) and I found out that the culprit was the ScrollBar.
> 
> A change to the ScrollBar has been issued already (it will come with KDE 4.9.1 I guess), so now it's time to clean up the hack and properly implement it.
> 
> The way this works is easy, we follow the conversation only if the last time the user scrolled, he scrolled to the end.
> 
> The patch also removes some useless debug info.
> 
> 
> This addresses bug 293522.
>     http://bugs.kde.org/show_bug.cgi?id=293522
> 
> 
> Diffs
> -----
> 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml 5eea8b7 
> 
> Diff: http://git.reviewboard.kde.org/r/105811/diff/
> 
> 
> Testing
> -------
> 
> Talked to myself in hope to see what I just wrote.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120801/740e0cea/attachment.html>