Review Request: Make it possible to filter for blocked/unblocked contacts

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104667/#review13059
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On April 19, 2012, 3:02 p.m., Dominik Cermak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104667/
> -----------------------------------------------------------
> 
> (Updated April 19, 2012, 3:02 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This adds a menuentry to contact-list where you can set which contacts should be shown:
>  * Show all contacts [that's how it is until now]
>  * Show unblocked contacts [default]
>  * Show blocked contacts
> 
> One annoying thing is that e.g. groups which have no contacts because of this filter still show up, together with the online contacts/total contacts count. This is true for all filters so maybe it's not such a big issue. Comments are welcome.
> 
> PS: I implemented it in the way the rest of contact-list is implemented, but should I use the same approach as in my last review (enum conversation) instead or let it this way?
> 
> 
> This addresses bug 294679.
>     http://bugs.kde.org/show_bug.cgi?id=294679
> 
> 
> Diffs
> -----
> 
>   contact-list-widget.h 9688c0c5c68bd9c182cf2e978d977de09d07cfc6 
>   contact-list-widget.cpp 0a1d434d9ec9bc3ea4eff4b241000e72c481b553 
>   main-widget.cpp b78cd3e433f6e81fc251e842053793db798e8011 
> 
> Diff: http://git.reviewboard.kde.org/r/104667/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dominik Cermak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120429/f3b99234/attachment.html>