Review Request: Use KUniqueApplication for log viewer
David Edmundson
kde at davidedmundson.co.uk
Fri Apr 20 14:39:07 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104683/#review12722
-----------------------------------------------------------
Completely agree with what this patch is trying to do.
However this is showing some rather horrific copy and paste laziness :)
logviewer/main.cpp
<http://git.reviewboard.kde.org/r/104683/#comment9939>
No.
logviewer/main.cpp
<http://git.reviewboard.kde.org/r/104683/#comment9941>
That's not my name.
logviewer/main.cpp
<http://git.reviewboard.kde.org/r/104683/#comment9940>
Also no.
- David Edmundson
On April 20, 2012, 4:35 a.m., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104683/
> -----------------------------------------------------------
>
> (Updated April 20, 2012, 4:35 a.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> The desktop file of log viewer specified that it's a unique application, and this make sense. So KUniqueApplication instead of QApplication should be used.
>
>
> Diffs
> -----
>
> logviewer/main.cpp c783e73
>
> Diff: http://git.reviewboard.kde.org/r/104683/diff/
>
>
> Testing
> -------
>
> Ok Here.
>
>
> Thanks,
>
> Xuetian Weng
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120420/e26abcbf/attachment.html>
More information about the KDE-Telepathy
mailing list