Review Request: Review Request : Bug 295840 - You can edit presence message for "offline" in the new status bar

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104594/#review12683
-----------------------------------------------------------


Getting there ;) I actually just tried to fix it and it's 6 lines of code in total. Hint: it's only in onCurrentIndexChanged(...) and one 'if' in event(...), because the line "if (e->type() == QEvent::FocusOut) {" is the one that makes it reappear for you ;)

Ping me on IRC and I'll explain.


global-presence-chooser.cpp
<http://git.reviewboard.kde.org/r/104594/#comment9934>

    This is wrong - never ever comment out (important) code without explaining why you did so.



global-presence-chooser.cpp
<http://git.reviewboard.kde.org/r/104594/#comment9935>

    Same here, this actually breaks stuff



global-presence-chooser.cpp
<http://git.reviewboard.kde.org/r/104594/#comment9936>

    This got you in a loop, because from onPresenceChanged(...) it calls setCurrentIndex(...), which triggers this slot, therefore calling onPresenceChanged(...) again.


- Martin Klapetek


On April 19, 2012, 6:43 p.m., moses alexander wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104594/
> -----------------------------------------------------------
> 
> (Updated April 19, 2012, 6:43 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Hi
> 
> This is patch for https://bugs.kde.org/show_bug.cgi?id=295840 . I am able to disallow editing of presence message when the user is Offline or Invisible. 
> 
> Comments and suggestions will be appreciated.
> 
> 
> Diffs
> -----
> 
>   global-presence-chooser.cpp 67e2b34 
> 
> Diff: http://git.reviewboard.kde.org/r/104594/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> moses alexander
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120419/bf0b4797/attachment.html>