Review Request: Make it possible to restore presence on login

[Dominik Cermak]

> On April 17, 2012, 12:39 p.m., Daniele Elmo Domenichelli wrote:
> > Do you have permissions to push on the main repository?

Why are you asking? I've pushed things in the past, so it should work now too. Assumed nobody changed my permissions, certainly.

Anyhow I'll wait for Martin's Ship It! before pushing it.


- Dominik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104363/#review12566
-----------------------------------------------------------


On April 14, 2012, 6:54 p.m., Dominik Cermak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104363/
> -----------------------------------------------------------
> 
> (Updated April 14, 2012, 6:54 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> It's a simple approach to have this feature implemented.
> It uses the ConnectsAutomatically property and the AutomaticPresence.
> In the kcm you can enable/disable this feature (ConnectsAutomatically is set) and on every presence change the new presence is set as the AutomaticPresence.
> This way mission-control cares for setting the saved presence as soon as possible.
> 
> Note: Disabling it takes only effect after the second login, I suspect something with the change notification between kcm and kded isn't working (that signal kcm should send and kded receive). So kded sets the property only after starting...
> 
> 
> This addresses bug 281929.
>     http://bugs.kde.org/show_bug.cgi?id=281929
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c55fa8431464b62a5426a6cf29319c3f6f5fce6f 
>   autoconnect.h PRE-CREATION 
>   autoconnect.cpp PRE-CREATION 
>   config/telepathy-kded-config.cpp 02ef9b43dba2f42b53b84ffb0ba695a3c89fd860 
>   config/telepathy-kded-config.ui e08e717f7682a66f8dd9e99bde5ead984bbce8c0 
>   telepathy-module.h 02cf37ccfb8db489ce7872f5b72b9cb06d40fe93 
>   telepathy-module.cpp ec27c985daa06d0967b4f8a83d1c8603fa01540b 
> 
> Diff: http://git.reviewboard.kde.org/r/104363/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dominik Cermak
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120417/938e3f9a/attachment-0001.html>