Review Request: Improve Chat Plasmoid size behavior

[Aleix Pol Gonzalez]

> On April 17, 2012, 12:12 p.m., Lasath Fernando wrote:
> > Neat patch. 
> > I do have a question though - what would this do if there are more active chats than can fit in a panel?

I __guess__ plasma won't enlarge the plasmoid further and you'll have to scroll it QML-style (drag). I think it's acceptable.


> On April 17, 2012, 12:12 p.m., Lasath Fernando wrote:
> > plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml, line 13
> > <http://git.reviewboard.kde.org/r/104633/diff/1/?file=56963#file56963line13>
> >
> >     I think according to the kde style guide, you're supposed to pad operators.
> >     
> >     i.e. put space before and after the '>'

? and : are already padded, if you pad everything, then it feels like an operator and words soup. I can do that, though.


> On April 17, 2012, 12:12 p.m., Lasath Fernando wrote:
> > plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml, line 25
> > <http://git.reviewboard.kde.org/r/104633/diff/1/?file=56963#file56963line25>
> >
> >     very cool ;-)

:D


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104633/#review12564
-----------------------------------------------------------


On April 17, 2012, 12:01 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104633/
> -----------------------------------------------------------
> 
> (Updated April 17, 2012, 12:01 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> This patch is quite cool.
>  - Report the list size as the minimum size
>  - If its shape is vertical (width<height) set a vertical orientation. This lets you put the plasmoid on a vertical panel
> 
> 
> Diffs
> -----
> 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml f548c33 
>   plasmoid/org.kde.ktp-chatplasmoid/metadata.desktop f949f65 
> 
> Diff: http://git.reviewboard.kde.org/r/104633/diff/
> 
> 
> Testing
> -------
> 
> Talked to myself a bit, again.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120417/c600900c/attachment.html>