Review Request: Improve and simplify Chat Delegates

[Lasath Fernando]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104635/#review12567
-----------------------------------------------------------

Ship it!


Patch is good. Just a few style issues.


plasmoid/org.kde.ktp-chatplasmoid/contents/ui/TextDelegate.qml
<http://git.reviewboard.kde.org/r/104635/#comment9841>

    Trailing whitespace



plasmoid/org.kde.ktp-chatplasmoid/contents/ui/TextDelegate.qml
<http://git.reviewboard.kde.org/r/104635/#comment9845>

    Can you break this up instead of having big fat line please. 
    
    It's much clearer to read that way.



plasmoid/org.kde.ktp-chatplasmoid/contents/ui/TextDelegate.qml
<http://git.reviewboard.kde.org/r/104635/#comment9842>

    Trailing whitespace


- Lasath Fernando


On April 17, 2012, 1:20 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104635/
> -----------------------------------------------------------
> 
> (Updated April 17, 2012, 1:20 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> - changes the TextDelegate to just display the text messages, puts the name on the section delegate
> - for outgoing chats, leaves the same text color and puts a background color to differenciate
> 
> 
> Diffs
> -----
> 
>   plasmoid/declarative-plugin/messages-model.h 4df6d11 
>   plasmoid/declarative-plugin/messages-model.cpp 92cd930 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml 41e16fd 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/TextDelegate.qml b205d77 
> 
> Diff: http://git.reviewboard.kde.org/r/104635/diff/
> 
> 
> Testing
> -------
> 
> Same as always, talked to myself.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120417/35f8cf0c/attachment-0001.html>