Review Request: On the Plasmoid, Just display 1 chat at the same time

Aleix Pol Gonzalez aleixpol at gmail.com
Fri Apr 13 01:55:09 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104575/#review12374
-----------------------------------------------------------


Like suggested David on IRC, I tried to use the currentIndex to define which one is shown. Patch: http://paste.kde.org/456494/

The problem with this is that we need make sure that just 1 is checked while the checked property is changed by onClicked itself, so we can't really attach this value to another property because the value ends up overriden. We might be able to fix this by making a hack (adding a checkedButton and exclusive property to make it think we're a button row) but in the end I think that the patch proposed here is straightforward enough.

- Aleix Pol Gonzalez


On April 13, 2012, 1:14 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104575/
> -----------------------------------------------------------
> 
> (Updated April 13, 2012, 1:14 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Only display 1 chat dialog at the same time. If a different contact is clicked, close the previously shown.
> 
> 
> Diffs
> -----
> 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml 3a9b71f 
> 
> Diff: http://git.reviewboard.kde.org/r/104575/diff/
> 
> 
> Testing
> -------
> 
> Roughly tried to reproduce the use case myself.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120413/cf4e64f7/attachment.html>


More information about the KDE-Telepathy mailing list