Review Request: When offline, add contact SNI should be hidden

Alexander Moses dsouza.alexander at gmail.com
Wed Apr 11 19:01:13 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104551/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

Hi

I'm working on https://bugs.kde.org/show_bug.cgi?id=294478 . What I've done is set the SNI to Passive and called setIconByName with an empty QString. But I don't think this will be sufficient. Please provide your suggestions.


Diffs
-----

  contact-request-handler.cpp 37d9996 

Diff: http://git.reviewboard.kde.org/r/104551/diff/


Testing
-------


Thanks,

Alexander Moses

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120411/249471dd/attachment-0001.html>


More information about the KDE-Telepathy mailing list