Review Request: Simplify the code for the MultiChat Plasmoid

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104543/#review12338
-----------------------------------------------------------

Ship it!


Looks good, thanks.

- David Edmundson


On April 11, 2012, 1:48 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104543/
> -----------------------------------------------------------
> 
> (Updated April 11, 2012, 1:48 a.m.)
> 
> 
> Review request for Telepathy and Martin Klapetek.
> 
> 
> Description
> -------
> 
> I wanted to implement some features to this chat UI, I found out the code looked a bit ugly and before doing anything further, I thought it would be better for you guys to review this.
> 
> Simplify the ConversationDelegate by actually using a Button and a QItemWidget, don't deal with plasma themes directly for no reason (if there was, I didn't see it).
> Unify the checked state of the chat views. Now there's not the problem when you press "Esc" that the Chat disappeared but the button remained pressed.
> 
> With this I'd like to implement to just show 1 chat at the same time, I think it's very important usability-wise.
> 
> 
> Diffs
> -----
> 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ConversationDelegate.qml aa667b7 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/main.qml bfb6f1a 
> 
> Diff: http://git.reviewboard.kde.org/r/104543/diff/
> 
> 
> Testing
> -------
> 
> I played with it for a while talking to myself. I have it on my panel, but nobody is alive at this time...
> 
> http://fc02.deviantart.net/fs71/f/2010/239/d/f/forever_alone_by_foreveraloneplz.png
> 
> If there's any way I can test it further, please tell me.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120411/9ff27f1b/attachment.html>