Review Request: (1/3) Add "Join Chat Room" button to the presence applet

David Edmundson kde at davidedmundson.co.uk
Tue Apr 10 13:35:58 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104533/#review12294
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On April 10, 2012, 1:34 p.m., Othmane Moustaouda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104533/
> -----------------------------------------------------------
> 
> (Updated April 10, 2012, 1:34 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Moving join chatroom dialog from contact-list to common-internals to make possible its use also by the presence applet 
> 
> 
> This addresses bug 293207.
>     http://bugs.kde.org/show_bug.cgi?id=293207
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3849c393e19bdc248939ef68a16dfe78b5f76b8d 
>   dialogs/join-chat-room-dialog.h d306e92ab36306c8cfb111590b5d797f6116ff27 
>   dialogs/join-chat-room-dialog.cpp d0487987941bbc2f40308e95807395edff1c98ab 
>   dialogs/join-chat-room-dialog.ui 2d077c46a42b7f922d497bc3ba07efe421b542de 
>   main-widget.cpp b78cd3e433f6e81fc251e842053793db798e8011 
>   rooms-model.h 894547248b8b7564ecea7e837c27da347ca60459 
>   rooms-model.cpp 36b2700c3f51d049f65a5fcc14042b8ecf69aad1 
> 
> Diff: http://git.reviewboard.kde.org/r/104533/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Othmane Moustaouda
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120410/ed7d4ae4/attachment.html>


More information about the KDE-Telepathy mailing list