Review Request: Never bring an account online from the kded

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104523/#review12267
-----------------------------------------------------------

Ship it!


You might want to remove the m_globalPresence completely as it has no purpose then. Otherwise Ship it!

- Martin Klapetek


On April 9, 2012, 12:08 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104523/
> -----------------------------------------------------------
> 
> (Updated April 9, 2012, 12:08 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Never bring an account online from the kded. SetPresence now only affects already online accounts.
> 
> Also is a tiny step towards the non-global presence.
> 
> 
> Diffs
> -----
> 
>   telepathy-module.h 3c94576 
>   telepathy-module.cpp f834b43 
> 
> Diff: http://git.reviewboard.kde.org/r/104523/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120409/db60ac01/attachment.html>