Review Request: Approve Stream Tubes. (1/2)

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104465/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

Approves ssh stream tubes.

Shows an indicator. Also keeps the status notifier persistent allowing the user to close the connection at any time (useful for a windowless tube, like the ssh-contact server)

It currently only handles 1 type of tube in a very non-flexible way. I shall improve on that at some point in the near future when I've worked out how best to do that. (Ideally I want to load a set of .desktop files I think, I need to talk to George K about his plans with upstream).

I figured it'd be better to get this merged than do one super huge harder to read patch.


Diffs
-----

  src/CMakeLists.txt 1d6f697 
  src/approverdaemon.cpp d8239b7 
  src/channelapprover.cpp 4130a86 
  src/ktpapprovermodule.cpp e71d5b9 
  src/streamtubechannelapprover.h PRE-CREATION 
  src/streamtubechannelapprover.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/104465/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120402/7a934443/attachment-0001.html>