Review Request: Don't use proxy model to filter matching contacts.

Commit Hook null at kde.org
Sun Apr 1 18:27:33 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104458/#review12099
-----------------------------------------------------------


This review has been submitted with commit dc502a40bec543bbec341667bea703ab1a53562e by Dan Vrátil to branch master.

- Commit Hook


On April 1, 2012, 3:56 p.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104458/
> -----------------------------------------------------------
> 
> (Updated April 1, 2012, 3:56 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Fixes a crash in the runner.
> 
> The crash was occurring in the proxy model which was used for filtering matching contacts. This patch drops the proxy model completely; contacts are now matched manually in the source model.
> 
> 
> This addresses bug 296547.
>     http://bugs.kde.org/show_bug.cgi?id=296547
> 
> 
> Diffs
> -----
> 
>   src/contactrunner.h 8a9a1839a25b6dc61409cb94981ca9906a27bc43 
>   src/contactrunner.cpp e16e13413ad85206610f89a6815bede08a8da823 
> 
> Diff: http://git.reviewboard.kde.org/r/104458/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vratil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120401/f993a783/attachment.html>


More information about the KDE-Telepathy mailing list