Review Request: Load and save passwords to KWallet

David Edmundson kde at davidedmundson.co.uk
Fri Sep 30 14:21:19 UTC 2011



On Sept. 30, 2011, 1:36 p.m., David Edmundson wrote:
> > For the rest it looks o, but before shipping I'd like to know what happens now if one has/doesn't have the gnome keyring installed and/or the auth handler? are the password always synchronized? which one takes precedence if for some reason they are different (i.e. one modifies the pw using empathy?)
> >
> 
> David Edmundson wrote:
>     As per GK suggestions, I'll drop support for writing passwords to MC. 
>     
>     That solves most those questions. If the user doesn't have the auth handler installed it won't work, but frankly I won't care.
> 
> Daniele Elmo Domenichelli wrote:
>     +1, but then we probably want to wait to push this until andrunko's auth handler is ready...

It's /my/ auth handler! 
Anyway, Andrunko said he can't finish off the TLS stuff. But he has added the relevant code in TpQt4 now, which is the bit I couldn't do.

Password stuff works fine. Will get the main repo all pushed up to date tonight.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102741/#review6963
-----------------------------------------------------------


On Sept. 30, 2011, 9:11 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102741/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2011, 9:11 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Load and save passwords to KWallet.
> 
> 
> Diffs
> -----
> 
>   src/add-account-assistant.cpp 43b55b6 
>   src/edit-account-dialog.cpp 8e9cde8 
> 
> Diff: http://git.reviewboard.kde.org/r/102741/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20110930/25580fff/attachment.html>


More information about the KDE-Telepathy mailing list