Review Request: Save group's expanded state and restore it on load

David Edmundson kde at davidedmundson.co.uk
Thu Sep 29 11:18:08 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102728/#review6905
-----------------------------------------------------------

Ship it!


I think I might rework this to work with accounts too, but this is good for now.

Ship it!


main-widget.cpp
<http://git.reviewboard.kde.org/r/102728/#comment6119>

    comment why we do this. 
    
    If there is no parent, this is a top level item that should be expanded/not .. or something


- David Edmundson


On Sept. 28, 2011, 8:44 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102728/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2011, 8:44 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Currently the groups are always collapsed. This patch should save the state of the group and restore it upon creating the group again. It can be expanded only if it contains something (calling expand() on an empty group does nothing and will not expand it upon first item being inserted).
> 
> 
> This addresses bugs 277216 and 282206.
>     http://bugs.kde.org/show_bug.cgi?id=277216
>     http://bugs.kde.org/show_bug.cgi?id=282206
> 
> 
> Diffs
> -----
> 
>   main-widget.h 876ff92 
>   main-widget.cpp aa93617 
> 
> Diff: http://git.reviewboard.kde.org/r/102728/diff/diff
> 
> 
> Testing
> -------
> 
> Connected to ICQ with 7 groups, expanded some, closed CL, relaunched, groups were as I left them.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20110929/b5db21eb/attachment-0001.html>


More information about the KDE-Telepathy mailing list