Review Request: Handle delivery error reports

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102718/#review6869
-----------------------------------------------------------

Ship it!


Only real comment is "the remote contact is not valid" doesn't really make any sense to a user. Hopefully it will never come up.
Also add "messageInfo.setStatus(QLatin1String("error")); " somewhere.
It adds an extra class to the div which some themes can choose to render differently.
(from the arbitrary defined 'spec' %status% here: http://trac.adium.im/wiki/CreatingMessageStyles)


- David Edmundson


On Sept. 27, 2011, 2:51 p.m., George Kiagiadakis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102718/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2011, 2:51 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This patch adds support for handling delivery error reports and showing the error messages in the text ui. This is not the best way to handle those reports, and there are still other kinds of delivery reports that need to be handled, but this is the best short-term solution.
> 
> In the long term, I am thinking of having an icon next to each message that indicates its delivery status, with a mouseover popup that reveals the error message (if there is an error). This way we can also handle "delivery success" reports and other kinds of reports (see the spec for details), like skype and kopete handle them (for protocols that support these features of course).
> 
> 
> Diffs
> -----
> 
>   lib/chat-widget.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102718/diff/diff
> 
> 
> Testing
> -------
> 
> Chatting still works fine. I haven't yet received a delivery error report, so I don't know yet if this works.
> 
> 
> Thanks,
> 
> George Kiagiadakis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20110927/9a4a46bc/attachment.html>