Review for gkiagia's krfb port to StreamTubeServer

[Olli Salli]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 25.09.2011 21:26, Olli Salli wrote:
> Hi,
> 
> George has a branch at
> http://cgit.collabora.com/git/user/gkiagia/krfb.git/log/?h=new-tubes-api, but
> there's no corresponding merge request (and krfb is not really one of
> our projects... in theory, at least)
> 
> I'm going to focus on the TP side of things, as I don't really know the
> krfb internals.
> 
> --

One further thing:

>    Tp::AccountFactoryPtr  accountFactory = Tp::AccountFactory::create(
>            QDBusConnection::sessionBus(), Tp::Account::FeatureCore);
>
>    Tp::ConnectionFactoryPtr connectionFactory =
> Tp::ConnectionFactory::create(
>      QDBusConnection::sessionBus(), Tp::Connection::FeatureCore);

The Accounts and Connections don't seem to be used at all, so you
shouldn't need to put any features in the factories. They'll only cause
overhead (extra D-Bus roundtrips before the tube is even given to
StreamTubeServer internals and hence offered).

Br,
Olli
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJOf4t7AAoJEAQQkupGanj4M+sH/jCnHd88rnlWhHienZHYg0ja
RVyxcQ6ikpv+oxNhUWOnCld20Kh6EYgA8L4Nst1Gdo6Su1jgNSj+iuqZ2mw/vw98
KVBkz9LF257vdqPE71Ou92UQjlbiNVfzjlwH+CL441PqpfvjzvTDlxd0tOgm/pLb
QKmNpqku8WDHGhf3lUREANXuRXgcj2OyCcvksfMihapwUnNTVgu6N+QO8t7XiDZc
ypyRJLxAcxvO4sEfjodZ2v3yFmfCBQCJsj28x+ktZbrAxU9z1anZ4hM6yNbu60QA
IdRe/kBntiFzrGeB5Dtd95ngSou04tzhmHIPYgeBQt1hbVvLLChjOgm0n95mLlw=
=YGpf
-----END PGP SIGNATURE-----