Review Request: Make the style-loading suck less

[Dominik Schmidt]

> On Sept. 20, 2011, 12:58 p.m., David Edmundson wrote:
> > lib/chat-window-style.cpp, line 44
> > <http://git.reviewboard.kde.org/r/102654/diff/1/?file=36390#file36390line44>
> >
> >     QHash<InternalIdentifier, QString> would be better.
> >     
> >     (or just a QStringList and treat the enum as an int  which is technically faster)

QHash<InternalIdentifier, QString> would be better.

Yes, but InternalIdentifier is a private type and i wanted to avoid making the classes friends. Can do that too of course.

I don't get your second suggestion, sorry.


> On Sept. 20, 2011, 12:58 p.m., David Edmundson wrote:
> > lib/chat-window-style.cpp, line 345
> > <http://git.reviewboard.kde.org/r/102654/diff/1/?file=36390#file36390line345>
> >
> >     Whilst I agree with your comment, lets avoid swearing in code.

okay s/bloody//


- Dominik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102654/#review6672
-----------------------------------------------------------


On Sept. 18, 2011, 7:53 a.m., Dominik Schmidt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102654/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2011, 7:53 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> DRY ...
> 
> Please do nitpick about style errors, I haven't done any KDE Telepathy coding in months so it's hard for me to remember the coding style or even stick to it :P
> 
> 
> You won't notice any difference on the surface, it's just refactoring inside.
> 
> 
> Diffs
> -----
> 
>   lib/chat-window-style.h 32fe4fd 
>   lib/chat-window-style.cpp 7186759 
> 
> Diff: http://git.reviewboard.kde.org/r/102654/diff
> 
> 
> Testing
> -------
> 
> The config ui works just fine
> 
> 
> Thanks,
> 
> Dominik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20110920/3247eccc/attachment.html>