Review Request: Make using local-xmpp a checkbox in the KCM just like Empathy does

Tue Sep 20 11:03:41 UTC 2011

> On Sept. 20, 2011, 9:46 a.m., Martin Klapetek wrote:
> > Pretty cool work, I'm just not sure I like the frame being turned into listview after enabling it, but then again, it's my personal feeling. Otherwise very good!

Maybe it is not the best way to do it, and I've being thinking if it was better to use a normal widget for that, but in my opinion this approach has some good points in favor:

0) Saves a lot of time in coding just by adding 2 filters to the model
1) The style is consistent with the other accounts, the user will realize that it is just another account and not some kind of voodoo magic.
1b) If for some reason the style of the accounts will be changed in the future, this will be changed es well, and we won't need to change this frame to keep consistency
2) You get the same features (status, error messages, etc) handled by the delegate
3) You can disable, edit or remove the account like any other account... when you remove it it switches back to the enable frame
4) If for some weird reason you manage to get 2 local-xmpp accounts, you can handle both of them from the listview (even though the widget won't get bigger, you will get a scrollbar) therefore you will be able to fix the situation. This won't happen if you use a "static" widget.

On the other hand, maybe it is possible to change the background color from white to gray, but I'm not sure if this is a good idea...

- Daniele Elmo

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102669/#review6663
-----------------------------------------------------------

On Sept. 19, 2011, 11:06 p.m., Daniele Elmo Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102669/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2011, 11:06 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> As discussed at Woshibon 2011!
> See the screenshots...
> Since the patch is quite big, you can find the git branch here:
> 
> http://quickgit.kde.org/?p=clones%2Ftelepathy-accounts-kcm%2Fddomenichelli%2Ftelepathy-accounts-kcm.git&a=shortlog&h=refs/heads/salut
> 
> 
> This addresses bug 282198.
>     http://bugs.kde.org/show_bug.cgi?id=282198
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt c55c04622e177283007460d51593a39fccb07b55 
>   src/KCMTelepathyAccounts/profile-list-model.h 63e5a16c46e6fcaa33fb4ed00d0affdb3ad8491c 
>   src/KCMTelepathyAccounts/profile-list-model.cpp c7536ab8433138273a63ddbb3fd7d37ffbd51c5f 
>   src/KCMTelepathyAccounts/profile-select-widget.h 4bb92a153721b25abf44a6da52495c480fc03085 
>   src/KCMTelepathyAccounts/profile-select-widget.cpp 0d5c804d25eede91b8a9ded5523e4ca9087bd8d8 
>   src/account-item.h 809b93f85d111bbf13595d263faa450ff79f0073 
>   src/account-item.cpp 033ac44bfed06965b8efd842d75c33fa4d8a3bb5 
>   src/accounts-list-model.h cc81c1e3e417eb8e6a35a4b8fb48205fea430452 
>   src/accounts-list-model.cpp e7bbeca9f923f21e42a06ea0a3046ed1329cc5e0 
>   src/kcm-telepathy-accounts.h 6f6c3138bc39373c8b7050b2164354aabd758d07 
>   src/kcm-telepathy-accounts.cpp 8d0a1cb4816055b4ddcfa8c0a377d8f1b11c0e32 
>   src/main-widget.ui 1499951c28007c9166712b05df81bcb6e3ece77a 
>   src/salut-enable-dialog.h PRE-CREATION 
>   src/salut-enable-dialog.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102669/diff
> 
> 
> Testing
> -------
> 
> Added and removed accounts several times, uninstalled salut, edited parameters, and more
> 
> 
> Screenshots
> -----------
> 
> Enable local-xmpp frame
>   http://git.reviewboard.kde.org/r/102669/s/264/
> Local-xmpp account enabled
>   http://git.reviewboard.kde.org/r/102669/s/265/
> Salut not found
>   http://git.reviewboard.kde.org/r/102669/s/266/
> 
> 
> Thanks,
> 
> Daniele Elmo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20110920/1e0fe83d/attachment-0001.html>