Review Request: Make using local-xmpp a checkbox in the KCM just like Empathy does

Mon Sep 19 23:07:32 UTC 2011

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102669/#review6650
-----------------------------------------------------------


The second screenshot shows a little bug (after adding the new local-xmpp account no item is selected but the edit and remove button are enabled), but it is already fixed on my branch

- Daniele Elmo


On Sept. 19, 2011, 11:06 p.m., Daniele Elmo Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102669/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2011, 11:06 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> As discussed at Woshibon 2011!
> See the screenshots...
> Since the patch is quite big, you can find the git branch here:
> 
> http://quickgit.kde.org/?p=clones%2Ftelepathy-accounts-kcm%2Fddomenichelli%2Ftelepathy-accounts-kcm.git&a=shortlog&h=refs/heads/salut
> 
> 
> This addresses bug 282198.
>     http://bugs.kde.org/show_bug.cgi?id=282198
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt c55c04622e177283007460d51593a39fccb07b55 
>   src/KCMTelepathyAccounts/profile-list-model.h 63e5a16c46e6fcaa33fb4ed00d0affdb3ad8491c 
>   src/KCMTelepathyAccounts/profile-list-model.cpp c7536ab8433138273a63ddbb3fd7d37ffbd51c5f 
>   src/KCMTelepathyAccounts/profile-select-widget.h 4bb92a153721b25abf44a6da52495c480fc03085 
>   src/KCMTelepathyAccounts/profile-select-widget.cpp 0d5c804d25eede91b8a9ded5523e4ca9087bd8d8 
>   src/account-item.h 809b93f85d111bbf13595d263faa450ff79f0073 
>   src/account-item.cpp 033ac44bfed06965b8efd842d75c33fa4d8a3bb5 
>   src/accounts-list-model.h cc81c1e3e417eb8e6a35a4b8fb48205fea430452 
>   src/accounts-list-model.cpp e7bbeca9f923f21e42a06ea0a3046ed1329cc5e0 
>   src/kcm-telepathy-accounts.h 6f6c3138bc39373c8b7050b2164354aabd758d07 
>   src/kcm-telepathy-accounts.cpp 8d0a1cb4816055b4ddcfa8c0a377d8f1b11c0e32 
>   src/main-widget.ui 1499951c28007c9166712b05df81bcb6e3ece77a 
>   src/salut-enable-dialog.h PRE-CREATION 
>   src/salut-enable-dialog.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102669/diff
> 
> 
> Testing
> -------
> 
> Added and removed accounts several times, uninstalled salut, edited parameters, and more
> 
> 
> Screenshots
> -----------
> 
> Enable local-xmpp frame
>   http://git.reviewboard.kde.org/r/102669/s/264/
> Local-xmpp account enabled
>   http://git.reviewboard.kde.org/r/102669/s/265/
> Salut not found
>   http://git.reviewboard.kde.org/r/102669/s/266/
> 
> 
> Thanks,
> 
> Daniele Elmo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20110919/a4321897/attachment-0001.html>