Review Request: A few small fixes
Commit Hook
null at kde.org
Mon Sep 19 22:50:39 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102667/#review6649
-----------------------------------------------------------
This review has been submitted with commit ab41d8362a42f5d50a14573d005707a650de7d2e by Daniele E. Domenichelli to branch master.
- Commit
On Sept. 19, 2011, 4:38 p.m., Daniele Elmo Domenichelli wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102667/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2011, 4:38 p.m.)
>
>
> Review request for Telepathy.
>
>
> Summary
> -------
>
> * Hide password from debug output
> * Reconnect account after editing only if required
> * Enable editing account by double clicking on it
> * Remove unused paramFound variable
>
>
> Diffs
> -----
>
> src/KCMTelepathyAccounts/account-edit-widget.cpp 0d7ab44862a8a642e5fb3d4e59cf499759d5c683
> src/accounts-list-model.h cc81c1e3e417eb8e6a35a4b8fb48205fea430452
> src/edit-account-dialog.cpp cb77d9a99defaf3d14af96a222fc5077cb79bdd1
> src/kcm-telepathy-accounts.cpp 8d0a1cb4816055b4ddcfa8c0a377d8f1b11c0e32
>
> Diff: http://git.reviewboard.kde.org/r/102667/diff
>
>
> Testing
> -------
>
> * Password is hidden
> * Accepting edit account dialog without changing values doesn't reconnect
> * Double clicking on an item on the view opens the edit file dialog
> * Build warning removed
>
>
> Thanks,
>
> Daniele Elmo
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20110919/1ff0c8b9/attachment.html>
More information about the KDE-Telepathy
mailing list