Review Request: Define QT_NO_CAST_FROM_ASCII and fix build

Fri Sep 16 16:43:22 UTC 2011

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102635/
-----------------------------------------------------------

Review request for Telepathy, David Edmundson and Martin Klapetek.

Summary
-------

Since some parts will be moved to a library it is better to define QT_NO_CAST_FROM_ASCII

Diffs
-----

  CMakeLists.txt 45594a05dfe8971a786d326eb8020500644d5ea8 
  adiumxtra-protocol-handler/adiumxtra-protocol-handler.cpp 9ce134b69310f158552abbe61e4050f15fd45a90 
  adiumxtra-protocol-handler/chat-style-installer.cpp bf3e012c2393c973bf648d102afaa9547ea25717 
  adiumxtra-protocol-handler/emoticon-set-installer.cpp 7a7556463cfa641fad731bb733f582fcd1bce2b3 
  app/chat-tab.cpp f973bc63ca17046dcc7309f958467367533cb894 
  app/chat-window.cpp 1ef738fa81b0a1ca38a35252b76293a3f32f8f34 
  app/telepathy-chat-ui.cpp b5e99d7b39396357f95d9ebbd971a051b5a561d4 
  config/appearance-config.cpp 481f17857eb8318da426dd9779d538cc687a66aa 
  config/behavior-config.cpp 26a65a6a9e1673f7bf4a10dcdd93cbd659563393 
  lib/adium-theme-message-info.cpp 71597e361b515ace50c440f097e07b0a52dce919 
  lib/adium-theme-view.cpp 74e5a966ecc8c02f8306072b1f81dce6d0a80130 
  lib/channel-contact-model.cpp 7887880ac9736b1769c5493c93d350b02067ef26 
  lib/chat-search-bar.cpp 0659f93765c1fac69bc3e3806d36a332021eeef5 
  lib/chat-style-plist-file-reader.cpp 250f01fdca0a49bae819265c424027cddcd7efa4 
  lib/chat-widget.cpp 2e0d9b1b3b2c37d56a151202f6eb68ee0c145e49 
  lib/chat-window-style-manager.cpp 815d6f255d4ea5e49b8b8f333d071cb774a8c39b 
  lib/chat-window-style.cpp 7186759ebfc6ace621128b92095e0adaad189556 

Diff: http://git.reviewboard.kde.org/r/102635/diff

Testing
-------

Build, run, try a little chat

Thanks,

Daniele Elmo

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20110916/b1cb60c5/attachment.html>