Review Request: First round of MainWidget refactor

[Francesco Nwokeka]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102584/#review6436
-----------------------------------------------------------



avatar-button.cpp
<http://git.reviewboard.kde.org/r/102584/#comment5710>

    why this? can't you simply connect to the loadFromFileButton signal clicked?



avatar-button.cpp
<http://git.reviewboard.kde.org/r/102584/#comment5711>

    again, why this?



avatar-button.cpp
<http://git.reviewboard.kde.org/r/102584/#comment5712>

    can you put this on the same line?


- Francesco


On Sept. 12, 2011, 9:53 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102584/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2011, 9:53 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> This first patch moves avatar handling code outside of the class and renames/moves some slots.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b01272f 
>   avatar-button.h PRE-CREATION 
>   avatar-button.cpp PRE-CREATION 
>   contact-delegate-overlay.cpp 5fe83ab 
>   main-widget.h bc3d1f8 
>   main-widget.ui 73c4333 
>   models/accounts-model.cpp 17846bf 
> 
> Diff: http://git.reviewboard.kde.org/r/102584/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20110912/24135d02/attachment.html>