Review Request: Added config KCM to configure tab behavior in the Text UI

[Francesco Nwokeka]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102561/#review6379
-----------------------------------------------------------

Ship it!


Looks cool to me. Just a few trivial coding standard errors to sort out.


config/appearance-config.h
<http://git.reviewboard.kde.org/r/102561/#comment5679>

    could you put these after the slots?



config/appearance-config.cpp
<http://git.reviewboard.kde.org/r/102561/#comment5682>

    * on the left of the variable



config/appearance-config.cpp
<http://git.reviewboard.kde.org/r/102561/#comment5683>

    * on the left of the variable



config/behavior-config.h
<http://git.reviewboard.kde.org/r/102561/#comment5680>

    close the "*" here and set your email right



config/behavior-config.h
<http://git.reviewboard.kde.org/r/102561/#comment5681>

    * on the left of the member


- Francesco


On Sept. 9, 2011, 7:14 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102561/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2011, 7:14 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> - Added config KCM to configure tab behavior in the Text UI Based on the work by Lasath Fernando
> 
> I've made it look 
> 
> - Removed the accounts kcm out of the chat handler as it's a weird thing to have there.
> 
> For screenshots look here: https://git.reviewboard.kde.org/r/101886/
> It's the same except there are two entries in the left panel instead of tabs.
> 
> 
> Diffs
> -----
> 
>   app/chat-window.cpp b3407db79f15632d640fc020674d6509739033bc 
>   config/CMakeLists.txt 2433c75207bfa4c1697c904f553756315a07f66d 
>   config/appearance-config.h PRE-CREATION 
>   config/appearance-config.cpp PRE-CREATION 
>   config/appearance-config.ui PRE-CREATION 
>   config/behavior-config.h PRE-CREATION 
>   config/behavior-config.cpp PRE-CREATION 
>   config/behavior-config.ui PRE-CREATION 
>   config/kcm_telepathy_chat_appearance_config.desktop PRE-CREATION 
>   config/kcm_telepathy_chat_behavior_config.desktop PRE-CREATION 
>   config/kcm_telepathy_chat_config.desktop c1588237972bffb31ed60d31c4113828350f08c9 
> 
> Diff: http://git.reviewboard.kde.org/r/102561/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20110910/24376263/attachment.html>