Review Request: Add basic drag&drop support for groups model

[Martin Klapetek]

> On Sept. 6, 2011, 4:19 p.m., David Edmundson wrote:
> > models/groups-model.cpp, line 174
> > <http://git.reviewboard.kde.org/r/102543/diff/1/?file=35495#file35495line174>
> >
> >     What's this for?
> >

Both this and the 'int beginRow' are useless leftovers from the research times. Forgot to clean this up.


> On Sept. 6, 2011, 4:19 p.m., David Edmundson wrote:
> > models/groups-model.cpp, line 194
> > <http://git.reviewboard.kde.org/r/102543/diff/1/?file=35495#file35495line194>
> >
> >     connect this to generalOperationFinished at least.
> >     
> >     We have lots of times when adding a user to a group fails when the server doesn't allow it, we need to report it.

Ok, I'll add a routing signal from groups model and connect it in main widget (ie. PendingOp -> Groups Model reemit that signal -> Main Widget connects it to the generalOperationFinished).


> On Sept. 6, 2011, 4:19 p.m., David Edmundson wrote:
> > models/groups-model.cpp, line 177
> > <http://git.reviewboard.kde.org/r/102543/diff/1/?file=35495#file35495line177>
> >
> >     I'm not entirely sure I like the way we're storing this. Effectively we have a stringlist which goes
> >     
> >     contact
> >     account
> >     contact
> >     account
> >     
> >     given we're just talking about a few people accepting this drag data it might make more sense to store it as "account/contact" as a single string so it's a bit clearer on how to unpack our data.
> >     I don't know.

The reason I went with this was the unpredictable account id and/or contact id. Let's say we set '/' as a delimiter. But what if one of the ids have '/' in it? So I went for two separate strings. But if my reasoning is invalid, I have no problems with one string.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102543/#review6302
-----------------------------------------------------------


On Sept. 6, 2011, 3:37 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102543/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2011, 3:37 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> It's what it says. You can drag contacts around your groups. When you drag it from 'Ungrouped', the contact is actually not copied but always moved (why would you want to have it in Ungrouped anyway?).
> 
> 
> This addresses bug 279657.
>     http://bugs.kde.org/show_bug.cgi?id=279657
> 
> 
> Diffs
> -----
> 
>   main-widget.cpp b477500 
>   models/groups-model.h f838897 
>   models/groups-model.cpp 1ee874a 
> 
> Diff: http://git.reviewboard.kde.org/r/102543/diff
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20110906/3133302e/attachment.html>