Review Request: Create preview for all file types, not only images

Commit Hook null at kde.org
Mon Oct 31 19:07:45 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103002/#review7781
-----------------------------------------------------------


This review has been submitted with commit 494d8014169e0a2429f0ad480e78a6a63297964d by Martin Klapetek to branch master.

- Commit Hook


On Oct. 31, 2011, 6:16 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103002/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2011, 6:16 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Up until now there was a preview only for images, now it allows one to preview all previewable files. This however raises a small concern about trying to preview big files, which could take long time. Next patch will show the mimetype icon and our favorite spinning wheel while the preview is being loaded.
> 
> Also features some .ui improvements (the new vertical layout was added for the new label that should be there in next version, see https://bugs.kde.org/show_bug.cgi?id=285414 ).
> 
> 
> Diffs
> -----
> 
>   mainwindow.h 4c40102 
>   mainwindow.cpp 64b41e1 
>   mainwindow.ui d99ce3b 
> 
> Diff: http://git.reviewboard.kde.org/r/103002/diff/diff
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> Screenshots
> -----------
> 
> File preview
>   http://git.reviewboard.kde.org/r/103002/s/320/
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111031/dd5552ea/attachment-0001.html>


More information about the KDE-Telepathy mailing list