Review Request: Fix empty fields for facebook account

Francesco Nwokeka francesco.nwokeka at gmail.com
Wed Oct 26 11:06:20 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102972/
-----------------------------------------------------------

(Updated Oct. 26, 2011, 11:06 a.m.)


Review request for Telepathy.


Changes
-------

updated patch moving validation code to main-options-widget-facebook.cpp


Description
-------

This patch checks that both fields have been filled when adding a facebook account. 


This addresses bug 279110.
    http://bugs.kde.org/show_bug.cgi?id=279110


Diffs (updated)
-----

  plugins/gabble/main-options-widget-facebook.h 0f5f42f 
  plugins/gabble/main-options-widget-facebook.cpp 7f6ef22 
  src/add-account-assistant.cpp 3614cc6 

Diff: http://git.reviewboard.kde.org/r/102972/diff/diff


Testing
-------

Tried to create an account with empty values. Got prompted to fill fields


Thanks,

Francesco Nwokeka

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111026/88437bd8/attachment-0001.html>


More information about the KDE-Telepathy mailing list