Review Request: Error dictionary for human readable errors

[Daniele Elmo Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102959/#review7653
-----------------------------------------------------------


It's already marked as submitted but anyway a few more comments...
1) About thread-safety I suggest removing QObject as base class, since it looks like useless here, and using K_GLOBAL_STATIC.
2) Since it's quite probably that this class will end in a library, you should move the private members into a private class.
3) It should be into a namespace (KTelepathy for example, since it is used in other places) to avoid symbol problems

- Daniele Elmo Domenichelli


On Oct. 25, 2011, 9:20 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102959/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2011, 9:20 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Never display a dbus error again.
> 
> 
> This addresses bug 282205.
>     http://bugs.kde.org/show_bug.cgi?id=282205
> 
> 
> Diffs
> -----
> 
>   error-dictionary.h 4a47536 
>   error-dictionary.cpp 401825a 
> 
> Diff: http://git.reviewboard.kde.org/r/102959/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111026/7bf5487e/attachment-0001.html>