Review Request: Don't allow creation of duplicate accounts
David Edmundson
kde at davidedmundson.co.uk
Tue Oct 25 12:50:31 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102962/#review7602
-----------------------------------------------------------
I'm not sure this works, displayName is just an arbitrary string. Doesn't have to have anything to do with the account name on the server or anything.
Tbh, I don't think this fix is actually possible (or why the bug was filed in the first place)
Still; This patch stops people ending up with identical looking entries in the Accounts KCM so I guess that's a good thing.
- David Edmundson
On Oct. 24, 2011, 3:24 p.m., Francesco Nwokeka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102962/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2011, 3:24 p.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> This patch checks if the account the user wants to create isn't already created
>
>
> This addresses bug 277845.
> http://bugs.kde.org/show_bug.cgi?id=277845
>
>
> Diffs
> -----
>
> src/add-account-assistant.cpp 80ed055
>
> Diff: http://git.reviewboard.kde.org/r/102962/diff/diff
>
>
> Testing
> -------
>
> Tried to create a duplicate account. Got an information message box telling me that the account already exists
>
>
> Thanks,
>
> Francesco Nwokeka
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111025/2ca36789/attachment.html>
More information about the KDE-Telepathy
mailing list