Review Request: Error dictionary for human readable errors

David Edmundson kde at davidedmundson.co.uk
Mon Oct 24 14:43:51 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102959/#review7576
-----------------------------------------------------------



error-dictionary.h
<http://git.reviewboard.kde.org/r/102959/#comment6568>

    m_ = member variable.
    
    static things aren't member variables, this should be s_


- David Edmundson


On Oct. 24, 2011, 12:20 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102959/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2011, 12:20 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Never display a dbus error again.
> 
> 
> This addresses bug 282205.
>     http://bugs.kde.org/show_bug.cgi?id=282205
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 17fd7f8 
>   error-dictionary.h PRE-CREATION 
>   error-dictionary.cpp PRE-CREATION 
>   error-handler.cpp ada02cc 
> 
> Diff: http://git.reviewboard.kde.org/r/102959/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111024/eed45603/attachment.html>


More information about the KDE-Telepathy mailing list