Review Request: Special presence for 'Now playing' plugin - CL part

David Edmundson kde at davidedmundson.co.uk
Sun Oct 23 18:25:13 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102950/#review7562
-----------------------------------------------------------

Ship it!


The slight issue with this is it doesn't tie you in very well with a particular state, online, away etc... 
ship it, maybe something will become clearer later.

- David Edmundson


On Oct. 23, 2011, 5:21 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102950/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2011, 5:21 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This adds a special presence 'Now listening to...' (now when looking at it, it could use better wording) which activates the mpris plugin in kded, so only after selecting this presence it actually uses the mpris-plugin presence.
> 
> Not sure how to handle this in the presence plasmoid. Probably in the same way (special presence)? 
> 
> 
> Diffs
> -----
> 
>   global-presence-chooser.cpp 439aeb0 
> 
> Diff: http://git.reviewboard.kde.org/r/102950/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111023/1de56efb/attachment.html>


More information about the KDE-Telepathy mailing list