Review Request: Merge all the pending reviews of key handling, and fix everything.

Francesco Nwokeka francesco.nwokeka at gmail.com
Thu Oct 20 14:39:48 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102908/#review7507
-----------------------------------------------------------

Ship it!


Ship It!

- Francesco Nwokeka


On Oct. 18, 2011, 7:31 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102908/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2011, 7:31 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Replace the crazy mix of signals and slots and event filters with mostly simple event propagation.
> 
> Keyboard shortcut for copy in the main chat area works, removed a hack for .moc loading.
> Generally tidier.  
> 
> 
> Diffs
> -----
> 
>   lib/adium-theme-view.h 0403c8c 
>   lib/adium-theme-view.cpp 9edfdbe 
>   lib/chat-text-edit.h 350f5d2 
>   lib/chat-text-edit.cpp 1f19d9d 
>   lib/chat-widget.h 61538c9 
>   lib/chat-widget.cpp 5fedbd4 
> 
> Diff: http://git.reviewboard.kde.org/r/102908/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111020/0bba6732/attachment.html>


More information about the KDE-Telepathy mailing list