Review Request: Make pressing enter key in presence dialog combobox work

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102865/#review7341
-----------------------------------------------------------



dialogs/custom-presence-dialog.cpp
<http://git.reviewboard.kde.org/r/102865/#comment6414>

    Definitely do not need this and your event filter.
    
    So why does this not work and your event filter does?



dialogs/custom-presence-dialog.cpp
<http://git.reviewboard.kde.org/r/102865/#comment6415>

    worth checking keyEvent->modifiers() is empty too.


- David Edmundson


On Oct. 14, 2011, 5:11 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102865/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2011, 5:11 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Adds event filter that catches the return key and does the needed magic that is otherwise broken, fixes bug 283802.
> 
> 
> This addresses bug 283802.
>     http://bugs.kde.org/show_bug.cgi?id=283802
> 
> 
> Diffs
> -----
> 
>   dialogs/custom-presence-dialog.h 4a764a9 
>   dialogs/custom-presence-dialog.cpp 94e2f75 
> 
> Diff: http://git.reviewboard.kde.org/r/102865/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111014/7f4d4b82/attachment.html>