Review Request: Add a spinning overlay to global presence chooser to indicate activity
Commit Hook
null at kde.org
Fri Oct 14 12:12:38 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102859/#review7333
-----------------------------------------------------------
This review has been submitted with commit fc8c39ada011bb3410b1dd4e49c8bb09596ba763 by Martin Klapetek to branch master.
- Commit Hook
On Oct. 14, 2011, 9:53 a.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102859/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2011, 9:53 a.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Initially I wanted to change the icon directly, but it's impossible to get the icon to spin. So I user KPixmapSequenceOverlayPainter and the spinning circle is being painted on the right side with 22px offset from the edge.
>
>
> This addresses bug 283800.
> http://bugs.kde.org/show_bug.cgi?id=283800
>
>
> Diffs
> -----
>
> global-presence-chooser.h 75f2c39
> global-presence-chooser.cpp fc2818c
> global-presence.cpp c1594f8
> presence-model.cpp 0d0bd42
>
> Diff: http://git.reviewboard.kde.org/r/102859/diff/diff
>
>
> Testing
> -------
>
> Works.
>
>
> Thanks,
>
> Martin Klapetek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111014/64532056/attachment.html>
More information about the KDE-Telepathy
mailing list