Git submodules

[David Edmundson]

Repos now using the submodule:

telepathy-contact-list
telepathy-contact-applet
telepathy-send-file

Also I've had a chat with Albert.
Scripty has no idea about submodules which means translations are an issue.

Currently there are no i18n commands in the submodule, so it's not a
problem. However as soon as we add any we need to do some extra work
to fix it - we can do this by adding a Messages.sh file inside the
submodule, and each app can use a KCatalogLoader to load it. If you
want to add anything with i18n into the submodule please let me know
ASAP - and it might be easier just to avoid doing so.

Dave

On Mon, Oct 10, 2011 at 10:37 PM, Alin Marin Elena
<alinm.elena at gmail.com> wrote:
> Dave, can you list the affected packages please?
>
> Alin
>
> On Monday 10 October 2011 22:14:45 you wrote:
>> Submodules are pushed! If your packages start breaking this is probably why.
>>
>> If you think something is a candidate for being in the submodule push
>> it. I'm making a blog post tonight about how to move a file between
>> repos.
>>
>> If you want your repo to use the git submodule, just ask me and I'll
>> help update it.
>>
>> All code in the git submodule should (maybe after 0.2) be completely
>> library ready, use of d pointers, properly designed API, well
>> commented etc.
>>
>> Bad APIs on anything (except maybe the models) for anything in the
>> common-repo should be reported as bugs.
>>
>> Having been the sucker who touched the git submodule stuff I can't
>> wait until it's turned into a regular lib. The sooner that happens the
>> better.
>>
>> Dave
>>
>> 2011/10/10 Alin Marin Elena <alinm.elena at gmail.com>:
>> > I have spoken with the boys... and I packaged it. no real issues.
>> > the workaround was too get add two git sources...
>> > https://build.opensuse.org/package/files?package=telepathy-contact-
>> > list&project=home%3Aealin%3Akde-telepathy
>> >
>> > from my point of view there is not too much trouble...
>> >
>> > Alin
>> >
>> > On Monday 10 October 2011 00:42:02 David Edmundson wrote:
>> >> On Sun, Oct 9, 2011 at 9:14 PM, David Edmundson
>> >>
>> >> <david at davidedmundson.co.uk> wrote:
>> >> > I tried updating the contact list to use the git submodule
>> >> > telepathy-common-internals
>> >> >
>> >> > It mostly went smoothly but I have two issues:
>> >> >
>> >> > If I ship as-is people need to run "git submodule init" "git submodule
>> >> > update" before their code will compile.
>> >> >
>> >> > I tried adding it into CMakeFiles.txt as
>> >> > execute_process(COMMAND git update blah blah blah WORKING_DIRECTORY
>> >> > ${CMAKE_SRC_DIR} )
>> >> >
>> >> > This works, but only when they run cmake twice, the first time it
>> >> > errors that the cpp files (from the submodule) aren't there before
>> >> > running my execute line. The second time it's fine.
>> >> > No idea why.
>> >> >
>> >> > Also - it's going to completely break making tarballs.
>> >> > I assume it makes sense for the tarballs to have the code for the git
>> >> > sub-repo in part of the tarball. This means my cmake line to run "git
>> >> > submodule init" etc. will break everything.
>> >> >
>> >> > I'm not sure how to do this in a way that's nice for normal users, and
>> >> > isn't going to make every packager want to murder me.
>> >> >
>> >> > Dave
>> >>
>> >> Update:
>> >>
>> >> Spoke to George K and came up with a plan between us. The
>> >> CMakeLists.txt file only updates git submodules if the file
>> >> ".gitmodules" is present. When building tarballs the submodule
>> >> contents will be fetched, and this .gitmodules file should be removed
>> >> as it makes no sense when not in git mode.
>> >>
>> >> Could someone review my moving changes in my scratch repo at. It's not
>> >> really a sensible patch for RB as it's a lot of moving about.
>> >> git://anongit.kde.org/scratch/davidedmundson/telepathy-contact-list
>> >> master branch
>> >>
>> >> I'd be interested to hear from alin (or another packager) to know that
>> >> everything still behaves correctly.
>> >>
>> >> Dave
>> >> _______________________________________________
>> >> KDE-Telepathy mailing list
>> >> KDE-Telepathy at kde.org
>> >> https://mail.kde.org/mailman/listinfo/kde-telepathy
>> >
>> > --
>> >  Without Questions there are no Answers!
>> >  ______________________________________________________________________
>> >  Alin Marin ELENA
>> >  Advanced Molecular Simulation Research Laboratory
>> >  School of Physics, University College Dublin
>> >  ----
>> >  Ardionsamblú Móilíneach Saotharlann Taighde
>> >  Scoil na Fisice, An Coláiste Ollscoile, Baile Átha Cliath
>> >
>> >  -------------------------------------------------------------------------
>> > ---------- http://alin.elenaworld.net
>> >  ______________________________________________________________________
>> > _______________________________________________
>> > KDE-Telepathy mailing list
>> > KDE-Telepathy at kde.org
>> > https://mail.kde.org/mailman/listinfo/kde-telepathy
> --
>  Without Questions there are no Answers!
>  ______________________________________________________________________
>  Alin Marin ELENA
>  Advanced Molecular Simulation Research Laboratory
>  School of Physics, University College Dublin
>  ----
>  Ardionsamblú Móilíneach Saotharlann Taighde
>  Scoil na Fisice, An Coláiste Ollscoile, Baile Átha Cliath
>
>  -----------------------------------------------------------------------------------
>  http://alin.elenaworld.net
>  ______________________________________________________________________