Review Request: KDED Module refactor

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102804/#review7219
-----------------------------------------------------------



telepathy-module.cpp
<http://git.reviewboard.kde.org/r/102804/#comment6304>

    You've not really addressed any of my comments here, and this code is somewhat crucial.
    
    At least add a check for double insert. It can easily happen as you don't always remove directly when one becomes inactive.
    
    just a simple
    if (active) {
      if (m_pluginStack.contains(m_plugin) {
         return;
      }
    
    I'm not sure what would happen if you it's in the stack twice, but it's not ideal.
    
    I'd like to see this loop tidied up too (as suggested last review), but I'm happy to let that slide till afterwards.
      
     


- David Edmundson


On Oct. 9, 2011, 6:23 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102804/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2011, 6:23 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Quite a big rewrite of the KDED module. The main changes are:
> 
> 1/ Use stacking system for plugins
>    --each plugin has its own priority, if the priority is higher than what's currently in stack, the plugin is placed on top, if it's lower, it's placed below (maintaining the order by priorities)
> 
> 2/ Plugins now use this sort-of API
>   --when any plugin wants to set a presence, it signals active(true); which is connected to the module's core where it checks the stack and either uses that plugin's presence or places it somewhere down the stack
> 
> 3/ Plugins all have common base class
> 
> 4/ 'Now listening...' aka mpris plugin was gifted with some refactoring as well
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 143afef 
>   autoaway.h a95f49a 
>   autoaway.cpp 812ba97 
>   global-presence.h PRE-CREATION 
>   global-presence.cpp PRE-CREATION 
>   telepathy-kded-module-plugin.h PRE-CREATION 
>   telepathy-kded-module-plugin.cpp PRE-CREATION 
>   telepathy-module.h 815ee38 
>   telepathy-module.cpp 174cecf 
>   telepathy-mpris.h 5dd596f 
>   telepathy-mpris.cpp b4920d8 
> 
> Diff: http://git.reviewboard.kde.org/r/102804/diff/diff
> 
> 
> Testing
> -------
> 
> 1/ Works
> 2/ Works
> 3/ Works too, obviously
> 4/ Still not with configurable message, but works
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111010/11dade5c/attachment.html>