Review Request: Create haze plugin for accounts kcm

David Edmundson kde at davidedmundson.co.uk
Sun Oct 9 14:17:41 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102812/#review7201
-----------------------------------------------------------



plugins/haze/msn-main-options-widget.h
<http://git.reviewboard.kde.org/r/102812/#comment6301>

    You don't work for Collabora (yet)
    Fix this.



plugins/haze/msn-main-options-widget.cpp
<http://git.reviewboard.kde.org/r/102812/#comment6300>

    This isn't you.


- David Edmundson


On Oct. 9, 2011, 1:50 p.m., Francesco Nwokeka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102812/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2011, 1:50 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Added msn-haze to the accounts settings. This is a basic setup for the moment (only login id and password). Will be working on the advanced settings soon
> 
> 
> This addresses bug 283575.
>     http://bugs.kde.org/show_bug.cgi?id=283575
> 
> 
> Diffs
> -----
> 
>   plugins/haze/CMakeLists.txt 7460936 
>   plugins/haze/haze-account-ui-plugin.cpp e05ae07 
>   plugins/haze/haze-msn-account.h PRE-CREATION 
>   plugins/haze/haze-msn-account.cpp PRE-CREATION 
>   plugins/haze/msn-main-options-widget.h PRE-CREATION 
>   plugins/haze/msn-main-options-widget.cpp PRE-CREATION 
>   plugins/haze/msn-main-options-widget.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102812/diff/diff
> 
> 
> Testing
> -------
> 
> uninstalled butterfly and used haze instead.
> 
> 
> Thanks,
> 
> Francesco Nwokeka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111009/b0ceb7e5/attachment.html>


More information about the KDE-Telepathy mailing list