Review Request: Add Global Presence drop down menu to the contact list

[Rohan Garg]

> On Oct. 8, 2011, 2:26 p.m., Martin Klapetek wrote:
> > main-widget.ui, line 78
> > <http://git.reviewboard.kde.org/r/102805/diff/2/?file=38142#file38142line78>
> >
> >     The combobox should have a maxWidth set, because if the contact list is opened with very long presence message, the window gets veeeeeeery wide. Don't forget text eliding. Perhaps the better place for this would be the GlobalPresenceChooser ctor.

This is actually automatically handled, the max width is set to the max width of the contact list and the presence text is elided accordingly, is there something that I'm missing over here?


- Rohan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102805/#review7178
-----------------------------------------------------------


On Oct. 8, 2011, 1:46 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102805/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2011, 1:46 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> BOOM! Start of the global presence chooser. The UI may need some tweaks later, but it's already many commits long and I'd like to get this merged as soon as possible so everyone can start working on it and sorting out remaining parts together.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 1ff1c6b 
>   abstract-contact-delegate.h 5f73670 
>   abstract-contact-delegate.cpp 34e0d67 
>   dialogs/custom-presence-dialog.h PRE-CREATION 
>   dialogs/custom-presence-dialog.cpp PRE-CREATION 
>   global-presence-chooser.h PRE-CREATION 
>   global-presence-chooser.cpp PRE-CREATION 
>   global-presence.h PRE-CREATION 
>   global-presence.cpp PRE-CREATION 
>   kpresence.h PRE-CREATION 
>   kpresence.cpp PRE-CREATION 
>   main-widget.h b04cbd0 
>   main-widget.cpp 6a734e3 
>   main-widget.ui a84e682 
>   presence-model.h PRE-CREATION 
>   presence-model.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102805/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111008/b68075b3/attachment.html>