Review Request: Move accountManagerPtr from config to main applet class

[Francesco Nwokeka]

> On Oct. 3, 2011, 11:48 a.m., David Edmundson wrote:
> > src/config.cpp, line 36
> > <http://git.reviewboard.kde.org/r/102762/diff/1/?file=37809#file37809line36>
> >
> >     Why not set parents on these? Then you don't have to delete them.

parents needed have to be QWidgets. The Plasma::Applet is not a QWidget. That's why I don't set them and I have to delete the objects myself


> On Oct. 3, 2011, 11:48 a.m., David Edmundson wrote:
> > src/telepathy-contact.cpp, line 210
> > <http://git.reviewboard.kde.org/r/102762/diff/1/?file=37811#file37811line210>
> >
> >     You don't need any of these (not sure if you still need FeatureCore)

I need these


> On Oct. 3, 2011, 11:48 a.m., David Edmundson wrote:
> > src/telepathy-contact.cpp, line 248
> > <http://git.reviewboard.kde.org/r/102762/diff/1/?file=37811#file37811line248>
> >
> >     After the first run the config still exists until you start another config, and m_config will always be non 0.
> >     
> >     Simpler code, let it delete itself: 
> >     
> >     Config *config = new Config(...)
> >     connect(config, SIGNAL(newContactStuff...
> >     connect(config, SIGNAL(accepted()), config, SLOT(deleteLater());
> >     config->show();
> >     
> >     Then it will just delete itself when it's closed, which is what you want.

true, updated.


- Francesco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102762/#review7022
-----------------------------------------------------------


On Oct. 3, 2011, 11:17 a.m., Francesco Nwokeka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102762/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2011, 11:17 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> Moving the contactManagerPtr from the config class to the main applet lightens the applet. This because we don't keep track of every change made in the Tp model by creating the config object only when needed. Thus the models for display too.
> 
> 
> Diffs
> -----
> 
>   src/config.h 6d3e27d 
>   src/config.cpp 9734a83 
>   src/telepathy-contact.h ce7632f 
>   src/telepathy-contact.cpp 34ce6db 
> 
> Diff: http://git.reviewboard.kde.org/r/102762/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Francesco Nwokeka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111003/e6a43412/attachment-0001.html>