Review Request: Add spell dictionary combobox to text-ui

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103296/#review8621
-----------------------------------------------------------

Ship it!



app/chat-window.h
<http://git.reviewboard.kde.org/r/103296/#comment7286>

    Indent please.



app/chat-window.h
<http://git.reviewboard.kde.org/r/103296/#comment7287>

    What on earth is going on with the documentation here.
    
    /** Description of the method */
    void theMethod();
    
    not below the line.
    
    If we ran this through doxygen it would make no sense.
    
    (tbh, this looks like the fault of an earlier person, I blame whoever made the text-ui)


- David Edmundson


On Nov. 30, 2011, 2:13 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103296/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2011, 2:13 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This is a finished patch of Alin's addition of combobox to the text-ui. All credit goes to him.
> 
> 
> Diffs
> -----
> 
>   app/chat-window.h 6cbc425 
>   app/chat-window.cpp d423965 
>   app/chatwindow.rc c24ddcc 
>   lib/chat-widget.h 31f13d6 
>   lib/chat-widget.cpp 2971b67 
> 
> Diff: http://git.reviewboard.kde.org/r/103296/diff/diff
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111130/7fd02e08/attachment-0001.html>