Review Request: Make creating yahoo! account work with entered @yahoo.com

Martin Klapetek martin.klapetek at gmail.com
Wed Nov 30 10:36:56 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103281/
-----------------------------------------------------------

(Updated Nov. 30, 2011, 10:36 a.m.)


Review request for Telepathy.


Changes
-------

Fixed issues from comments.


Description
-------

Haze requires yahoo! account to be without the @yahoo.com part. This patch removes that part if user adds it. It's imho better to do this than to put a big scary WARNING! above the line edit. Our software appears smart.


This addresses bug 287190.
    http://bugs.kde.org/show_bug.cgi?id=287190


Diffs (updated)
-----

  plugins/haze/yahoo-main-options-widget.h 592e582 
  plugins/haze/yahoo-main-options-widget.cpp 25d163e 

Diff: http://git.reviewboard.kde.org/r/103281/diff/diff


Testing
-------

Successfully added a yahoo! account and connected.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111130/996c6ce6/attachment-0001.html>


More information about the KDE-Telepathy mailing list