Review Request: Handle contact requests through KDED module

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103233/#review8460
-----------------------------------------------------------



contact-request-handler.h
<http://git.reviewboard.kde.org/r/103233/#comment7170>

    Why is this public?



contact-request-handler.cpp
<http://git.reviewboard.kde.org/r/103233/#comment7172>

    warning?



contact-request-handler.cpp
<http://git.reviewboard.kde.org/r/103233/#comment7171>

    May as well declare this inside the if directly
    
    Tp::PendingOperation *op = manager->....



contact-request-handler.cpp
<http://git.reviewboard.kde.org/r/103233/#comment7173>

    don't use the telepathy error messages directly. 
    
    They're all in a confusing form with dbus paths and crap. By all means print it to kDebug()/kWarning() but don't show it to the user, go through the error dictionary. 



contact-request-handler.cpp
<http://git.reviewboard.kde.org/r/103233/#comment7176>

    You probably want to watch the op from this.


- David Edmundson


On Nov. 25, 2011, 1:17 a.m., Dario Freddi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103233/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2011, 1:17 a.m.)
> 
> 
> Review request for Telepathy and Martin Klapetek.
> 
> 
> Description
> -------
> 
> This patch enables the KDED module to handle incoming authorization requests through a KSNI, based on the initial work of Martin. Warning: the code is currently untested as at the time I'm sending diff 1 I am unable to do so due to lack of time - please help by reviewing and testing the code.
> 
> 
> This addresses bug 285410.
>     http://bugs.kde.org/show_bug.cgi?id=285410
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 335d7f7 
>   contact-request-handler.h PRE-CREATION 
>   contact-request-handler.cpp PRE-CREATION 
>   telepathy-module.h 7215c0b 
>   telepathy-module.cpp 0c3ea5f 
> 
> Diff: http://git.reviewboard.kde.org/r/103233/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dario Freddi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111125/7ed63902/attachment-0001.html>