Review Request: Refactor ErrorDictionary to be a namespace and carrying Tp constants
Commit Hook
null at kde.org
Mon Nov 21 16:21:08 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103178/#review8366
-----------------------------------------------------------
This review has been submitted with commit cfc66161d8d37770a2fe25bd0118c06577739b62 by Dario Freddi to branch master.
- Commit Hook
On Nov. 18, 2011, 6:48 p.m., Dario Freddi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103178/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2011, 6:48 p.m.)
>
>
> Review request for Telepathy and Martin Klapetek.
>
>
> Description
> -------
>
> Instead of having a singleton and a hash, simply return the string when needed - single apps or library initializers should take care of loading catalogs. Also, no moar magic strings, but constants for your wicked minds.
>
>
> Diffs
> -----
>
> error-dictionary.h ee92d12
> error-dictionary.cpp 5f84b7b
>
> Diff: http://git.reviewboard.kde.org/r/103178/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dario Freddi
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111121/1cda56be/attachment.html>
More information about the KDE-Telepathy
mailing list