Review Request: Make global-presence-chooser editable on click while preserving popup on arrow-button click

Commit Hook null at kde.org
Mon Nov 21 14:39:13 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103170/#review8365
-----------------------------------------------------------


This review has been submitted with commit 736a0e3f6d37344abca818022ed6e82748acde52 by Martin Klapetek to branch master.

- Commit Hook


On Nov. 17, 2011, 3:37 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103170/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2011, 3:37 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> If you click the combobox arrow button, a popup with list of presences will be shown. If you click any other part of the combobox, it will turn itself into editable one allowing you to input your own presence message, which is set only if the user presses enter. When it loses focus, it is turned back into standard combo.
> 
> 
> Diffs
> -----
> 
>   global-presence-chooser.h c4e4302 
>   global-presence-chooser.cpp 56a066d 
> 
> Diff: http://git.reviewboard.kde.org/r/103170/diff/diff
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111121/45912513/attachment.html>


More information about the KDE-Telepathy mailing list