Review Request: Turn internals into a library (actually two)

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103183/#review8306
-----------------------------------------------------------


[23:41] <d_ed> one final thing - I've heard (though this may be wrong) using the KDE_EXPORT macro for anything outside kdelibs is naughty
[23:41] <d_ed> and you should make your own export macro
[23:41] <drf__> I'll change this in a later revision for sure though
[23:41] <d_ed> I'm going to put that as a review comment so it's not forgotten

- David Edmundson


On Nov. 18, 2011, 11:25 p.m., Dario Freddi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103183/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2011, 11:25 p.m.)
> 
> 
> Review request for Telepathy and George Goldberg.
> 
> 
> Description
> -------
> 
> This patch turns common-internals into a library. Here follows a shortlog of changes of what I did for making this happen:
> 
> 264472c Add CMake magic for making the library build
> bb7e95b Now that everything has been put into a namespace, rename KPresence to Presence for consistency
> ad52ffe Export the classes
> b587540 Add KTelepathy namespace to base classes
> b3ee5f6 Fix all warnings
> 83b2a68 Enforce the use of QLatin1*
> 5c8fc85 Enforce the non-use of Qt keywords
> 
> Missing:
>  * Fix paths (so move all the source code in a KTelepathy/ subfolder) for fixing includes in header files when including from other applications. I didn't do that in the review since it would have screwed up the diff badly.
>  * Port applications
> 
> George, I know you are reluctant towards this change, but the situation with the current submodules is getting unsustainable, and since we aim towards moving KTelepathy to Extragear for 0.3, we need to fix that. The concern about BC is not a problem, since we'll handle the SONUMBER accordingly, and the library will still be private for internal use until we decide for something different.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt PRE-CREATION 
>   circular-countdown.h 039ce75 
>   circular-countdown.cpp 0821e4c 
>   cmake/modules/COPYING-CMAKE-SCRIPTS PRE-CREATION 
>   cmake/modules/FindTelepathyQt4.cmake PRE-CREATION 
>   error-dictionary.h ee92d12 
>   error-dictionary.cpp 5f84b7b 
>   global-presence.h d782c3e 
>   global-presence.cpp 61f1457 
>   kpresence.h 81e702f 
>   kpresence.cpp 609ac24 
>   models/CMakeLists.txt PRE-CREATION 
>   models/accounts-filter-model.h 8b55abb 
>   models/accounts-filter-model.cpp 0665800 
>   models/accounts-model-item.h e3748b7 
>   models/accounts-model-item.cpp d854d8e 
>   models/accounts-model.h 825f113 
>   models/accounts-model.cpp 21f14cb 
>   models/contact-model-item.h c69d12f 
>   models/contact-model-item.cpp 67de9fa 
>   models/groups-model-item.cpp cbe3da2 
>   models/groups-model.h ef9b28e 
>   models/groups-model.cpp e56dc2a 
>   models/proxy-tree-node.h ae123d1 
>   models/proxy-tree-node.cpp e413509 
>   models/tree-node.h 9f675ab 
>   models/tree-node.cpp f892d5a 
>   presence.h PRE-CREATION 
>   presence.cpp PRE-CREATION 
>   service-availability-checker.h 8883fe6 
>   service-availability-checker.cpp 9b9e1d5 
>   telepathy-handler-application.h 455463d 
>   telepathy-handler-application.cpp ce28c26 
>   text-parser.h 7790b14 
>   text-parser.cpp 510c2a5 
>   wallet-interface.h 629dbe1 
> 
> Diff: http://git.reviewboard.kde.org/r/103183/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dario Freddi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111118/331282be/attachment.html>